lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dweiss <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #372: LUCENE-8267: removed references to memory cod...
Date Tue, 08 May 2018 07:15:09 GMT
Github user dweiss commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/372#discussion_r186636017
  
    --- Diff: solr/core/src/test/org/apache/solr/uninverting/TestFieldCacheVsDocValues.java
---
    @@ -619,6 +619,6 @@ private void assertEquals(long numOrds, TermsEnum expected, TermsEnum
actual) th
       
       protected boolean codecAcceptsHugeBinaryValues(String field) {
    --- End diff --
    
    Right, we don't. I actually removed larger conditional blocks of code after this method
is gone.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message