lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m-khl <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #371: SOLR-9685 tag a query in JSON syntax
Date Mon, 07 May 2018 14:43:01 GMT
Github user m-khl commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/371#discussion_r186444765
  
    --- Diff: solr/core/src/java/org/apache/solr/request/json/JsonQueryConverter.java ---
    @@ -69,6 +69,13 @@ private void buildLocalParams(StringBuilder builder, Object val, boolean
isQPars
                 "Error when parsing json query, expect only one query parser here, but found
: "+map.keySet());
           }
           String qtype = map.keySet().iterator().next();
    +      String qTypeTrimmed = qtype.trim();
    +      String tagName = null;
    +      if (qTypeTrimmed.startsWith("#")) {
    +        tagName = qTypeTrimmed.substring(1);
    --- End diff --
    
    I suppose it makes more sense to keep hash in tag just to make it more noticeable and
explicit. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message