From dev-return-320578-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Mon Apr 30 06:40:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B8067180647 for ; Mon, 30 Apr 2018 06:40:09 +0200 (CEST) Received: (qmail 39248 invoked by uid 500); 30 Apr 2018 04:40:03 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 39237 invoked by uid 99); 30 Apr 2018 04:40:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Apr 2018 04:40:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 553BDC0188 for ; Mon, 30 Apr 2018 04:40:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id kgaPa4ibrdKh for ; Mon, 30 Apr 2018 04:40:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E4FB35F4AE for ; Mon, 30 Apr 2018 04:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4FC17E0163 for ; Mon, 30 Apr 2018 04:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0BCCB21291 for ; Mon, 30 Apr 2018 04:40:00 +0000 (UTC) Date: Mon, 30 Apr 2018 04:40:00 +0000 (UTC) From: "Mark Miller (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (SOLR-12290) Improve our servlet stream closing prevention code for users and devs. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-12290?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Miller updated SOLR-12290: ------------------------------- Description:=20 Original Summary: When you fetch a file for replication we close the request output stream af= ter writing the file which ruins the connection for reuse. We can't close response output streams, we need to reuse these connections.= If we do, clients are hit will connection problems when they try and reuse= the connection from their pool. New Summary: At some point the above was addressed during refactoring. We should remove = these neutered closes and review our close shield code. If you are here to track down why this is done: Connection reuse requires that we read all streams and do not close them - = instead the container itself must manage request and response streams. If w= e allow them to be closed, not only do we lose some connection reuse, but w= e can cause spurious client errors that can cause expensive recoveries for = no reason. The spec allows us to count on the container to manage streams. = It's our job simply to not close them and to always read them fully, from c= lient and server.=20 Java itself can help with always reading the streams fully up to some small= default amount of unread stream slack, but that is very dangerous to count= on, so we always manually eat up anything on the streams our normal logic = ends up not reading for whatever reason. =C2=A0 =C2=A0 was: Original Summary: When you fetch a file for replication we close the request output stream af= ter writing the file which ruins the connection for reuse. We can't close response output streams, we need to reuse these connections.= If we do, clients are hit will connection problems when they try and reuse= the connection from their pool. New Summary: At some point the above was addressed during refactoring. We should remove = these neutered closes and review our close shield code. If you are here to track down why this is done: Connection reuse requires that we read all streams and do not close them - = instead the container itself must manage request and response streams. If w= e allow them to be closed, not only do we lose some connection reuse, but w= e can cause spurious client errors that can for expensive recoveries for no= reason. The spec allows us to count on the container to manage streams. It= 's our job simply to not close them and to always read them fully, from cli= ent and server.=20 Java itself can help with always reading the streams fully up to some small= default amount of unread stream slack, but that is very dangerous to count= on, so we always manually eat up anything on the streams our normal logic = ends up not reading for whatever reason. =C2=A0 =C2=A0 > Improve our servlet stream closing prevention code for users and devs. > ---------------------------------------------------------------------- > > Key: SOLR-12290 > URL: https://issues.apache.org/jira/browse/SOLR-12290 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public)=20 > Reporter: Mark Miller > Assignee: Mark Miller > Priority: Minor > Attachments: SOLR-12290.patch, SOLR-12290.patch, SOLR-12290.patch= , SOLR-12290.patch > > > Original Summary: > When you fetch a file for replication we close the request output stream = after writing the file which ruins the connection for reuse. > We can't close response output streams, we need to reuse these connection= s. If we do, clients are hit will connection problems when they try and reu= se the connection from their pool. > New Summary: > At some point the above was addressed during refactoring. We should remov= e these neutered closes and review our close shield code. > If you are here to track down why this is done: > Connection reuse requires that we read all streams and do not close them = - instead the container itself must manage request and response streams. If= we allow them to be closed, not only do we lose some connection reuse, but= we can cause spurious client errors that can cause expensive recoveries fo= r no reason. The spec allows us to count on the container to manage streams= . It's our job simply to not close them and to always read them fully, from= client and server.=20 > Java itself can help with always reading the streams fully up to some sma= ll default amount of unread stream slack, but that is very dangerous to cou= nt on, so we always manually eat up anything on the streams our normal logi= c ends up not reading for whatever reason. > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org