From dev-return-317651-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Wed Apr 4 17:14:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3B7AC18064F for ; Wed, 4 Apr 2018 17:14:03 +0200 (CEST) Received: (qmail 20522 invoked by uid 500); 4 Apr 2018 15:14:01 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 20512 invoked by uid 99); 4 Apr 2018 15:14:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 15:14:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 92A80C013E for ; Wed, 4 Apr 2018 15:14:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id XuSOcbX2cqwe for ; Wed, 4 Apr 2018 15:14:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CFE035FD30 for ; Wed, 4 Apr 2018 15:14:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 692BFE02A9 for ; Wed, 4 Apr 2018 15:14:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2709825614 for ; Wed, 4 Apr 2018 15:14:00 +0000 (UTC) Date: Wed, 4 Apr 2018 15:14:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-12095) AutoScalingHandler should validate triggers before updating zookeeper MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-12095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425675#comment-16425675 ] ASF subversion and git services commented on SOLR-12095: -------------------------------------------------------- Commit 2bbd19369137d2b31f44c94ce2de61f9047856f4 in lucene-solr's branch refs/heads/master from [~ab] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2bbd193 ] SOLR-12095: Missed a few calls to init(). > AutoScalingHandler should validate triggers before updating zookeeper > --------------------------------------------------------------------- > > Key: SOLR-12095 > URL: https://issues.apache.org/jira/browse/SOLR-12095 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Components: AutoScaling, SolrCloud > Reporter: Shalin Shekhar Mangar > Assignee: Andrzej Bialecki > Priority: Major > Fix For: 7.4, master (8.0) > > > We validate policy and preferences before updating the configuration in Zookeeper but we don't do that today for triggers. So users can put wrong or unknown parameters and there won't be any complains from the API but the at runtime exceptions will be thrown/logged. > We should change the trigger API to have a validation step. The catch here is that it may require us to instantiate the trigger class. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org