lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ignacio Vera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8236) GeoPath behavior with identical points
Date Wed, 04 Apr 2018 04:31:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424992#comment-16424992
] 

Ignacio Vera commented on LUCENE-8236:
--------------------------------------

Attached a patch with the logic for filtering points.

> GeoPath behavior with identical points
> --------------------------------------
>
>                 Key: LUCENE-8236
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8236
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Priority: Minor
>         Attachments: LUCENE-8326.patch
>
>
> GeoPath has the current behavior:
>  * When provided a path with two consecutive identical points: In all cases it generates
an {{IllegalArgumentException}} because it tries to build a plane with those two points.
>  * When provided a path with two consecutive numerical identical points: In case of {{GeoStandardPath}}
it throws an {{IllegalArgumentException}} because the path is too short. The case of {{GeoDegeneratePath}}
is more complicated as it builds the path but the plane can be bogus. In some cases points
on the other side of the world can be "In Set".
> I think the factory should filter out these points, in the same way it is done for {{GeoPolygon}}.
If this is not the desired behavior then the factory  should throw a consistent {{IllegalArgumentException}}
in all cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message