From dev-return-314210-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Thu Mar 8 21:58:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3287118064C for ; Thu, 8 Mar 2018 21:58:04 +0100 (CET) Received: (qmail 7891 invoked by uid 500); 8 Mar 2018 20:58:02 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 7881 invoked by uid 99); 8 Mar 2018 20:58:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Mar 2018 20:58:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3276D1A0700 for ; Thu, 8 Mar 2018 20:58:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -102.311 X-Spam-Level: X-Spam-Status: No, score=-102.311 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id has4gHKzFnir for ; Thu, 8 Mar 2018 20:58:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2E2095F232 for ; Thu, 8 Mar 2018 20:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9EA3FE026D for ; Thu, 8 Mar 2018 20:58:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 562F125416 for ; Thu, 8 Mar 2018 20:58:00 +0000 (UTC) Date: Thu, 8 Mar 2018 20:58:00 +0000 (UTC) From: =?utf-8?Q?Tom=C3=A1s_Fern=C3=A1ndez_L=C3=B6bbe_=28JIRA=29?= To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-11982) Add support for shards.sort parameter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-11982?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1639= 1900#comment-16391900 ]=20 Tom=C3=A1s Fern=C3=A1ndez L=C3=B6bbe commented on SOLR-11982: ---------------------------------------------- Thanks [~emaijala]. Code looks really good. I uploaded the latest patch and= left some minor comments there. One thing I'm not 100% yet is the pipe in = the syntax. To me, pipe usually means "OR", but in this case, that is not t= he case, the order of the elements in does affect the output. Your code can= also handle the comma separated clauses, so it seems like: {code:java}shards.sort=3DreplicaType:PULL|TLOG{code} Is actually the same as=20 {code:java}shards.sort=3DreplicaType:PULL,replicaType:TLOG{code} What is the intention of including the pipe then? > Add support for shards.sort parameter > ------------------------------------- > > Key: SOLR-11982 > URL: https://issues.apache.org/jira/browse/SOLR-11982 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public)=20 > Components: SolrCloud > Affects Versions: 7.3, master (8.0) > Reporter: Ere Maijala > Priority: Minor > Labels: patch-available, patch-with-test > Attachments: SOLR-11982.patch, SOLR-11982.patch, SOLR-11982.patch= , SOLR-11982.patch > > > It would be nice to have the possibility to easily sort the shards in the= preferred order e.g. by replica type. The attached patch adds support for = {{shards.sort}} parameter that allows one to sort e.g. PULL and TLOG replic= as first with {{shards.sor=3DreplicaType:PULL|TLOG }}(which would mean that= NRT replicas wouldn't be hit with queries unless they're the only ones ava= ilable) and/or to sort by replica location (like preferLocalShards=3Dtrue b= ut more versatile). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org