lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsmiley <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #323: SOLR-11731: LatLonPointSpatialField could be ...
Date Mon, 05 Mar 2018 17:06:51 GMT
Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/323#discussion_r172245429
  
    --- Diff: solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java ---
    @@ -485,6 +486,10 @@ private Object decodeDVField(int localId, LeafReader leafReader,
String fieldNam
           case SORTED_NUMERIC:
             final SortedNumericDocValues numericDv = leafReader.getSortedNumericDocValues(fieldName);
             if (numericDv != null && numericDv.advance(localId) == localId) {
    +          if (schemaField.getType() instanceof LatLonPointSpatialField) {
    --- End diff --
    
    I think this logic should go further below in the loop since there may be multiple points
per document.  Actually we should put this in `decodeNumberFromDV` which is invoked not only
from SORTED_NUMERIC but also from NUMERIC.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message