From dev-return-310363-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Thu Feb 1 15:14:10 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id EDCE0180652 for ; Thu, 1 Feb 2018 15:14:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DCF08160C44; Thu, 1 Feb 2018 14:14:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3160A160C26 for ; Thu, 1 Feb 2018 15:14:09 +0100 (CET) Received: (qmail 39255 invoked by uid 500); 1 Feb 2018 14:14:07 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 39245 invoked by uid 99); 1 Feb 2018 14:14:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2018 14:14:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 74A14C0558 for ; Thu, 1 Feb 2018 14:14:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 8roKJSIqq_VN for ; Thu, 1 Feb 2018 14:14:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0A47C5FB94 for ; Thu, 1 Feb 2018 14:14:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4778EE00A6 for ; Thu, 1 Feb 2018 14:14:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0BD0621E82 for ; Thu, 1 Feb 2018 14:14:00 +0000 (UTC) Date: Thu, 1 Feb 2018 14:14:00 +0000 (UTC) From: "Alan Woodward (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LUCENE-8145) UnifiedHighlighter should use single OffsetEnum rather than List MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-8145?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D163= 48629#comment-16348629 ]=20 Alan Woodward commented on LUCENE-8145: --------------------------------------- I've opened a pull request on github: [https://github.com/apache/lucene-sol= r/pull/317] Much easier to review than a series of patches... > UnifiedHighlighter should use single OffsetEnum rather than List > -------------------------------------------------------------------------= --- > > Key: LUCENE-8145 > URL: https://issues.apache.org/jira/browse/LUCENE-8145 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter > Reporter: Alan Woodward > Assignee: Alan Woodward > Priority: Minor > Attachments: LUCENE-8145.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The UnifiedHighlighter deals with several different aspects of highlighti= ng: finding highlight offsets, breaking content up into snippets, and passa= ge scoring.=C2=A0 It would be nice to split this up so that consumers can u= se them separately. > As a first step, I'd like to change the API of FieldOffsetStrategy to ret= urn a single unified OffsetsEnum, rather than a collection of them.=C2=A0 T= his will make it easier to expose the OffsetsEnum of a document directly fr= om the highlighter, bypassing snippet extraction and scoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org