From dev-return-310413-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Thu Feb 1 18:32:10 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id AF90C180652 for ; Thu, 1 Feb 2018 18:32:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8F528160C44; Thu, 1 Feb 2018 17:32:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D6923160C35 for ; Thu, 1 Feb 2018 18:32:09 +0100 (CET) Received: (qmail 17634 invoked by uid 500); 1 Feb 2018 17:32:08 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 17622 invoked by uid 99); 1 Feb 2018 17:32:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2018 17:32:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 072F71803CE for ; Thu, 1 Feb 2018 17:32:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id oJx4NgCIsVFd for ; Thu, 1 Feb 2018 17:32:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6D1375FC27 for ; Thu, 1 Feb 2018 17:32:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2DBF4E030D for ; Thu, 1 Feb 2018 17:32:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6CE75240AA for ; Thu, 1 Feb 2018 17:32:00 +0000 (UTC) Date: Thu, 1 Feb 2018 17:32:00 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-11882) SolrMetric registries retain references to SolrCores when closed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-11882?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1634= 8957#comment-16348957 ]=20 ASF subversion and git services commented on SOLR-11882: -------------------------------------------------------- Commit b586dca89ff0b7c365dcbb3e1e403adf477790b1 in lucene-solr's branch ref= s/heads/branch_7x from [~ab] [ https://git-wip-us.apache.org/repos/asf?p=3Dlucene-solr.git;h=3Db586dca ] Revert "SOLR-11882: SolrMetric registries retain references to SolrCores wh= en closed" This reverts commit 2feb3e794a03e07fa1eee34188d667f24d357db5. > SolrMetric registries retain references to SolrCores when closed > ---------------------------------------------------------------- > > Key: SOLR-11882 > URL: https://issues.apache.org/jira/browse/SOLR-11882 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public)=20 > Components: metrics, Server > Affects Versions: 7.1 > Reporter: Eros Taborelli > Assignee: Erick Erickson > Priority: Major > Fix For: 7.3 > > Attachments: SOLR-11882.patch, SOLR-11882.patch, SOLR-11882.patch= , SOLR-11882.patch, create-cores.zip, solr-dump-full_Leak_Suspects.zip, sol= r.config.zip > > > *Description:* > Our setup involves using a lot of small cores (possibly hundred thousand)= , but working only on a few of them at any given time. > We already followed all recommendations in this guide: [https://wiki.apac= he.org/solr/LotsOfCores] > We noticed that after creating/loading around 1000-2000=C2=A0empty cores,= with no documents inside, the heap consumption went through the roof despi= te having set transientCacheSize to only 64 (heap size set to 12G). > All cores are correctly set to loadOnStartup=3Dfalse and transient=3Dtrue= , and we have verified via logs that the cores in excess are actually being= closed. > However, a reference remains in the org.apache.solr.metrics.SolrMetricMan= ager#registries that is never removed until a core if fully unloaded. > Restarting the JVM loads all cores in the admin UI, but doesn't populate = the ConcurrentHashMap until a core is actually fully loaded. > I reproduced the issue on a smaller scale (transientCacheSize =3D 5, heap= size =3D 512m) and made a report (attached) using eclipse MAT. > *Desired outcome:* > When a transient core is closed, the references in the SolrMetricManager = should be removed, in the same fashion the reporters for the core are also = closed and removed. > In alternative, a unloadOnClose=3Dtrue|false flag could be implemented to= fully unload a transient core when closed due to the cache size. > *Note:* > The documentation mentions everywhere that the unused cores will be unloa= ded, but it's misleading as the cores are never fully unloaded. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org