From dev-return-312416-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Thu Feb 22 00:20:19 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F0EA318061A for ; Thu, 22 Feb 2018 00:20:18 +0100 (CET) Received: (qmail 58973 invoked by uid 500); 21 Feb 2018 23:20:17 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 58956 invoked by uid 99); 21 Feb 2018 23:20:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 23:20:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4887DC143D for ; Wed, 21 Feb 2018 23:20:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.002 X-Spam-Level: X-Spam-Status: No, score=-0.002 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Ti4tM6uOSfmI for ; Wed, 21 Feb 2018 23:20:15 +0000 (UTC) Received: from mail.sd-datasolutions.de (serv2.sd-datasolutions.de [78.47.65.36]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 5D6985F124 for ; Wed, 21 Feb 2018 23:20:15 +0000 (UTC) Received: from VEGA (p200300C103E7910178DEF99FA9557441.dip0.t-ipconnect.de [IPv6:2003:c1:3e7:9101:78de:f99f:a955:7441]) by mail.sd-datasolutions.de (Postfix) with ESMTPSA id 15218480FB7 for ; Wed, 21 Feb 2018 23:20:15 +0000 (UTC) X-NSA-Greeting: Dear NSA, have fun with reading and analyzing this e-mail! From: "Uwe Schindler" To: References: <012a01d3ab69$9e202960$da607c20$@thetaphi.de> In-Reply-To: Subject: RE: Test failures are out of control...... Date: Thu, 22 Feb 2018 00:20:14 +0100 Message-ID: <012d01d3ab6a$879924c0$96cb6e40$@thetaphi.de> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIpf+JmOyN3AvCI9SwPc57xzQeRBwK/C5v9AhKc7lYB4GHWLwJjOM2sAIpd0sICuvHY5QHGVUv8Aarc9CcBM7iwhQKgRgIRombWWEA= Content-Language: de Hey Yonik, Have you read my e-mail? I just said that there is no need to add = another sysprop as its already there! The default value for the sysprop = is just a common-build.xml one-line change. BTW, as I don't care about Solr tests most of the time, I disabled them = completely on my local machine using lucene.build.properties in my = user's home directory. Every developer can do the same on his own = lucene.build.properties file (e.g. enable/disable bad apples). Just the = default should be decided here. Uwe ----- Uwe Schindler Achterdiek 19, D-28357 Bremen http://www.thetaphi.de eMail: uwe@thetaphi.de > -----Original Message----- > From: Yonik Seeley [mailto:yseeley@gmail.com] > Sent: Thursday, February 22, 2018 12:17 AM > To: Solr/Lucene Dev > Subject: Re: Test failures are out of control...... >=20 > On Wed, Feb 21, 2018 at 6:13 PM, Uwe Schindler = wrote: > >> > There are exactly three > >> > BadApple annotations in the entire code base at present, is there > >> > enough value in introducing another annotation to make it = worthwhile? > >> > >> If we change BadApple tests to be executed by default for "ant = test" > >> (but not for the most frequent jenkins jobs), then that would be = fine. > >> Basically, add a -Dtests.disable-badapples and use that for the > >> jenkins jobs that email the list all the time. > > > > No need for a new sysprop. It's already there, just inverted! = Configuring > Jenkins to enable disable them is trivial. >=20 > The issue is that flakey tests should not be ignored by developers > running unit tests before committing new changes. That's the most > important point in time for test coverage. >=20 > -Yonik >=20 > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org > For additional commands, e-mail: dev-help@lucene.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org