lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8148) Get precommit Lint warnings out of test code
Date Thu, 01 Feb 2018 06:15:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348066#comment-16348066
] 

Robert Muir commented on LUCENE-8148:
-------------------------------------

Wouldn't it be more prudent to first fix the non-test code?

We still don't even fail on compiler warnings, which is the most very basic, step zero, of
static analysis (I feel inclined to bring this up on every one of these lets do fancy XYZ
static analysis issues, because its so sad).

> Get precommit Lint warnings out of test code
> --------------------------------------------
>
>                 Key: LUCENE-8148
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8148
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>
> Mostly putting this up for discussion. I'm starting to work on Solr test lint warnings,
it seems right to break the Lucene changes and Solr changes into separate JIRAs.
> First of all, do people have objections to me mucking around in the Lucene test code
to do this? The eventual goal here is to get to the point where we can turn on precommit failures
on lint warnings. Deprecations maybe as well, but that's a separate issue, as is non-test
code.
> I expect to see a lot of pretty safe issues, then a series I'm not sure of, I'll ask
when I find them if I wind up carrying this forward. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message