lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Woodward (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8145) UnifiedHighlighter should use single OffsetEnum rather than List<OffsetEnum>
Date Thu, 01 Feb 2018 14:14:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348629#comment-16348629
] 

Alan Woodward commented on LUCENE-8145:
---------------------------------------

I've opened a pull request on github: [https://github.com/apache/lucene-solr/pull/317]

Much easier to review than a series of patches...

> UnifiedHighlighter should use single OffsetEnum rather than List<OffsetEnum>
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-8145
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8145
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-8145.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The UnifiedHighlighter deals with several different aspects of highlighting: finding
highlight offsets, breaking content up into snippets, and passage scoring.  It would be nice
to split this up so that consumers can use them separately.
> As a first step, I'd like to change the API of FieldOffsetStrategy to return a single
unified OffsetsEnum, rather than a collection of them.  This will make it easier to expose
the OffsetsEnum of a document directly from the highlighter, bypassing snippet extraction
and scoring.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message