lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cassandra Targett (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11669) Policy Session lifecycle needs cleanup
Date Thu, 01 Feb 2018 16:41:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348871#comment-16348871
] 

Cassandra Targett commented on SOLR-11669:
------------------------------------------

[~noble.paul], should this issue be resolved? 

> Policy Session lifecycle needs cleanup
> --------------------------------------
>
>                 Key: SOLR-11669
>                 URL: https://issues.apache.org/jira/browse/SOLR-11669
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: AutoScaling
>            Reporter: Andrzej Bialecki 
>            Assignee: Noble Paul
>            Priority: Major
>
> {{Policy.Session}} is used in several places in the autoscaling framework. However, its
life-cycle is unclear and inconsistent - in some places ({{ComputePlanAction}}) sessions are
created directly via {{Policy.createSession}}, in other places a thread-local caching in {{PolicyHelper}}
is used, in still other places the {{ObjectCache}} is used.
> {{Session}} creates a copy of live nodes on instantiation, which may become stale, but
{{PolicyHelper}} caching never checks whether this instance is still valid while it's still
in cache.
> Also, refcounting leads to awkward and non-intuitive code, such AddReplicaCmd:103.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message