lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-10809) Get precommit lint warnings out of test code
Date Thu, 01 Feb 2018 04:33:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347999#comment-16347999
] 

Erick Erickson commented on SOLR-10809:
---------------------------------------

[~yseeley@gmail.com] Any objection to removing Closeble from DocSetBase? I'm looking at precommit
warnings in test code and this is one. This is the code, and if the off-heap idea isn't going
anywhere soon it seems like it could be removed:
{{  /** FUTURE: for off-heap */
  @Override
  public void close() throws IOException {
  }
}}

> Get precommit lint warnings out of test code
> --------------------------------------------
>
>                 Key: SOLR-10809
>                 URL: https://issues.apache.org/jira/browse/SOLR-10809
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>
> There are over 300 precommit WARNING messages in test files. Getting them out will largely
be rote maintenance. See SOLR-10778.
> If anyone is going to help here, please create a sub-task first identifying what you're
going to work on. Suggestion: Take a particular test _directory_, e.g.
> lucene/analysis/common/src/test/org/apache/lucene/analysis/ and create a sub-jira linked
back to this one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message