lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsmiley <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #317: LUCENE-8145: OffsetsEnum is now unitary
Date Thu, 01 Feb 2018 14:33:24 GMT
Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/317#discussion_r165372488
  
    --- Diff: lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/Passage.java
---
    @@ -193,8 +203,4 @@ public void setEndOffset(int endOffset) {
         this.endOffset = endOffset;
       }
     
    -  /** @lucene.internal */
    -  public void setScore(float score) {
    --- End diff --
    
    We should probably keep setScore(float) for users who want to build scores their own way.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message