From dev-return-308896-archive-asf-public=cust-asf.ponee.io@lucene.apache.org Tue Jan 16 09:36:15 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 1BCE118065B for ; Tue, 16 Jan 2018 09:36:15 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0BECD160C46; Tue, 16 Jan 2018 08:36:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5247A160C26 for ; Tue, 16 Jan 2018 09:36:14 +0100 (CET) Received: (qmail 12113 invoked by uid 500); 16 Jan 2018 08:36:12 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 12082 invoked by uid 99); 16 Jan 2018 08:36:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2018 08:36:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 37D0D18079F for ; Tue, 16 Jan 2018 08:36:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.711 X-Spam-Level: X-Spam-Status: No, score=-108.711 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 87iwijQg_jl9 for ; Tue, 16 Jan 2018 08:36:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 761E35FB29 for ; Tue, 16 Jan 2018 08:36:11 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 274D3E257E for ; Tue, 16 Jan 2018 08:36:09 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6DE4321302 for ; Tue, 16 Jan 2018 08:36:05 +0000 (UTC) Date: Tue, 16 Jan 2018 08:36:05 +0000 (UTC) From: "Amrit Sarkar (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-10734) Multithreaded test/support for AtomicURP broken MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-10734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326871#comment-16326871 ] Amrit Sarkar commented on SOLR-10734: ------------------------------------- Improvements listed in SOLR-11311. > Multithreaded test/support for AtomicURP broken > ----------------------------------------------- > > Key: SOLR-10734 > URL: https://issues.apache.org/jira/browse/SOLR-10734 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Ishan Chattopadhyaya > Assignee: Noble Paul > Priority: Major > Fix For: master (8.0), 7.3 > > Attachments: SOLR-10734.patch, SOLR-10734.patch, SOLR-10734.patch, Screen Shot 2017-05-31 at 4.50.23 PM.png, log-snippet, testMaster_2500, testResults7_10, testResultsMaster_10 > > > The multithreaded test doesn't actually start the threads, but only invokes the run directly. The join afterwards doesn't do anything, hence. > {code} > diff --git a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java > index f3f833d..10b7770 100644 > --- a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java > +++ b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java > @@ -238,7 +238,7 @@ public class AtomicUpdateProcessorFactoryTest extends SolrTestCaseJ4 { > } > } > }; > - t.run(); > + t.run(); // red flag, shouldn't this be t.start? > threads.add(t); > finalCount += index; //int_i > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org