lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8099) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery
Date Thu, 04 Jan 2018 19:10:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311873#comment-16311873
] 

Hoss Man commented on LUCENE-8099:
----------------------------------

bq. Re testing, replacement tests had already been committed as part of another issue

Cool -- thank you for clarifying, that wasn't obvious to me when skimming these particular
commits.

bq.  Maybe we should add some static methods to FunctionScoreQuery to allow for simple boosting?


+1

As i mentioned, I think it would be nice for backcompat if we could keep the old {{new FOO(xxx)}}
constructors working as trivial subclasses of FunctionScoreQuery -- but I get your point about
wanting to reduce confusion/ambiguity in the names.   A one line drop in replacement for each
of the 3 previous constructors that's easy for people to batch replace on upgrade should be
adequate.

As i alluded to in my earlier comment, the one other concern I have is about the relative
performance of the old classes vs using the FunctionScoreQuery. I haven't wrapped my head
around the old code vs new code enough to have any concrete concerns/objections -- I'm just
looking for some explicit "vote of confidence" from folks like you who _have_ looked at it
in depth that you've thought about it and don't see any reason why the new cosolidated impl
would be slower then the old impls.  

(The one thing that jumped out at me the other day was the use of a compiled expressions like
{{"score * context"}} in each query instance in the suggested replacement code for some queries
-- but it's not clear to me if that would still be involved based on your latest patch)

> Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery
> ----------------------------------------------------------
>
>                 Key: LUCENE-8099
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8099
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: 7.3
>
>         Attachments: LUCENE-8099-2.patch, LUCENE-8099.patch, LUCENE-8099.patch
>
>
> After LUCENE-7998, these three queries can all be replaced by a FunctionScoreQuery. 
Using lucene-expressions makes them much easier to use as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message