lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-11758) Missing boolVal implementation in FloatDocValues
Date Sat, 06 Jan 2018 03:51:00 GMT

     [ https://issues.apache.org/jira/browse/SOLR-11758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hoss Man updated SOLR-11758:
----------------------------
    Attachment: SOLR-11758.patch

Nice catch!

I expanded on your test a bit to prove that all of the numeric DocValue abstract FunctionValue
classes follow the same expected semantics for {{boolVal()}} and added some sanity check tests
at the solr level of the specific type of failure you encountered.

I'll commit soon unless anyone else spots any problems.

> Missing boolVal implementation in FloatDocValues
> ------------------------------------------------
>
>                 Key: SOLR-11758
>                 URL: https://issues.apache.org/jira/browse/SOLR-11758
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Munendra S N
>            Priority: Minor
>         Attachments: SOLR-11758.patch, SOLR-11758.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In case of *DoubleDocValues*, *boolVal(int doc)* has been implemented but this is missing
in case *FloatDocValues*.
> *Impact*: For any DocValues which extends *FloatDocValues* and doesn't implement *boolVal(int
doc)*, parent *boolVal* in FucntionValues would be called.
> boolVal implementation in FunctionValues
> {code:java}
>   @Override
>   public boolean boolVal(int doc) throws IOException {
>     return intVal(doc) != 0;
>   }
> {code}
> Let me know if I can work on it



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message