Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
MIME-Version: 1.0
References: <CAK8-Ou_uJAdOw5N3=1GSsD9PXGw6ew5v+sv6ifOOf8KfsywjFQ@mail.gmail.com>
 <CAPsWd+OA-duRd3s1rso6wiD6J5DLa7yAZ+H=3U0q-LvUbY7SvQ@mail.gmail.com>
In-Reply-To: <CAPsWd+OA-duRd3s1rso6wiD6J5DLa7yAZ+H=3U0q-LvUbY7SvQ@mail.gmail.com>
From: Adrien Grand <jpountz@gmail.com>
Date: Mon, 04 Dec 2017 09:57:21 +0000
Message-ID: <CAPsWd+PFbUEe4xUJxZFkaw0n1NJeQgDOmFhi6Co3STkDDUHVsA@mail.gmail.com>
Subject: Re: Potential bug in UsageTrackingQueryCachingPolicy
To: dev@lucene.apache.org
Content-Type: multipart/alternative; boundary="001a114a448839ae09055f80bf21"
archived-at: Mon, 04 Dec 2017 09:57:43 -0000

--001a114a448839ae09055f80bf21
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hey Jon,

FYI I fixed this bug you reported at
https://issues.apache.org/jira/browse/LUCENE-8078. Thanks again for
reporting it.

Le lun. 20 nov. 2017 =C3=A0 16:11, Adrien Grand <jpountz@gmail.com> a =C3=
=A9crit :

> Hi Jon,
>
> Sorry for the late reply. You are right that it should return true rather
> than false. Would you like to submit a patch?
>
> Le ven. 3 nov. 2017 =C3=A0 19:04, Jon Harper <jon.harper87@gmail.com> a =
=C3=A9crit :
>
>> Hi,
>>
>> I'm looking at lucene-core UsageTrackingQueryCachingPolicy.java (caching
>> policy for the LRUCache), one line of code looks dubious in the
>> shouldNeverCache method
>>
>> The comment says "For the below queries, it's cheap to notice they canno=
t
>> match any docs so     we do not bother caching them. "  but then returns
>> false to shouldnevercache for MatchNoDocsQuery
>>
>> Note that empty BooleanQuery and empty DisjunctionMaxQuery return true
>> and hence are never cached
>>
>> Here's a github link to the line in question for easy and quick access.
>>
>>
>> https://github.com/apache/lucene-solr/blob/1d2787464f4709f4960716dd3314c=
7123324b15b/lucene/core/src/java/org/apache/lucene/search/UsageTrackingQuer=
yCachingPolicy.java#L71
>>
>>
>> Regards,
>> Jon
>>
>

--001a114a448839ae09055f80bf21
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hey Jon,<br><br></div>FYI I fixed this bug you report=
ed at <a href=3D"https://issues.apache.org/jira/browse/LUCENE-8078">https:/=
/issues.apache.org/jira/browse/LUCENE-8078</a>. Thanks again for reporting =
it.<br></div><br><div class=3D"gmail_quote"><div dir=3D"ltr">Le=C2=A0lun. 2=
0 nov. 2017 =C3=A0=C2=A016:11, Adrien Grand &lt;<a href=3D"mailto:jpountz@g=
mail.com">jpountz@gmail.com</a>&gt; a =C3=A9crit=C2=A0:<br></div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc sol=
id;padding-left:1ex"><div dir=3D"ltr"><div>Hi Jon,<br><br></div>Sorry for t=
he late reply. You are right that it should return true rather than false. =
Would you like to submit a patch?<br></div><br><div class=3D"gmail_quote"><=
div dir=3D"ltr">Le=C2=A0ven. 3 nov. 2017 =C3=A0=C2=A019:04, Jon Harper &lt;=
<a href=3D"mailto:jon.harper87@gmail.com" target=3D"_blank">jon.harper87@gm=
ail.com</a>&gt; a =C3=A9crit=C2=A0:<br></div><blockquote class=3D"gmail_quo=
te" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"=
><div dir=3D"ltr"><div><div><span>Hi,<br><br>I&#39;m looking at lucene-core=
=20
UsageTrackingQueryCachingPolicy.java (caching policy for the LRUCache),=20
one line of code looks dubious in the shouldNeverCache method</span></div><=
br><span>The comment says &quot;For the below queries, it&#39;s cheap to no=
tice they cannot match any docs so<span>=C2=A0=C2=A0</span><span>=C2=A0=C2=
=A0</span> we do not bother caching them. &quot;<span>=C2=A0=C2=A0</span>bu=
t then returns false to shouldnevercache for MatchNoDocsQuery<br><br></span=
><span><span></span>Note that empty BooleanQuery and empty DisjunctionMaxQu=
ery return true and hence are never cached</span><br><br></div><div>Here=
9;s a github link to the line in question for easy and quick access.<br></d=
iv><div><br></div><span> <a href=3D"https://github.com/apache/lucene-solr/b=
lob/1d2787464f4709f4960716dd3314c7123324b15b/lucene/core/src/java/org/apach=
e/lucene/search/UsageTrackingQueryCachingPolicy.java#L71" rel=3D"noopener" =
target=3D"_blank">https://github.com/apache/lucene-solr/blob/1d2787464f4709=
f4960716dd3314c7123324b15b/lucene/core/src/java/org/apache/lucene/search/Us=
ageTrackingQueryCachingPolicy.java#L71</a><br><br><br></span><div><div>Rega=
rds,<br></div><div><div><div><div class=3D"m_6037072871215588211m_-20050520=
20813020249gmail_signature">Jon</div></div>
</div></div></div></div>
</blockquote></div></blockquote></div>

--001a114a448839ae09055f80bf21--