lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-8086) G3d wrapper: Improve circles for non spherical planets
Date Fri, 08 Dec 2017 18:36:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283991#comment-16283991
] 

ASF GitHub Bot commented on LUCENE-8086:
----------------------------------------

Github user iverase commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/288#discussion_r155843938
  
    --- Diff: lucene/spatial-extras/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShapeFactory.java
---
    @@ -150,10 +176,21 @@ public Rectangle rect(double minX, double maxX, double minY, double
maxY) {
     
       @Override
       public Circle circle(double x, double y, double distance) {
    -    GeoCircle circle = GeoCircleFactory.makeGeoCircle(planetModel,
    -        y * DistanceUtils.DEGREES_TO_RADIANS,
    -        x * DistanceUtils.DEGREES_TO_RADIANS,
    -        distance * DistanceUtils.DEGREES_TO_RADIANS);
    +    GeoCircle circle;
    +    if (planetModel.ab == planetModel.c) {
    --- End diff --
    
    I think spatial3d is a low level library in that respect, so it shouldn't have such a
method. Karl Wright has the last word, comment would be fine   


> G3d wrapper: Improve circles for non spherical planets
> ------------------------------------------------------
>
>                 Key: LUCENE-8086
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8086
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial-extras
>            Reporter: Ignacio Vera
>
> Hi [~dsmiley],
> The purpose of this ticket is to add a new circle shape (GeoExactCircle) for non-spherical
planets and therefore remove the method relate from Geo3dCircleShape. The patch will include
some simplifications on the wrapper and some refactoring of the tests.
> I will open shortly a pull request.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message