lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <>
Subject [jira] [Commented] (LUCENE-8071) GeoExactCircle should create circles with right number of planes
Date Fri, 01 Dec 2017 15:16:00 GMT


Karl Wright commented on LUCENE-8071:

Hi [~ivera], this would have been addressed by the backing planes too.
Essentially, when the circle becomes concave, the logic has to change for computing "within".
 That is the fundamental difference.

I think the fix is reasonable although I am not certain there aren't other cases besides the
initial split where this same logic would be needed.

> GeoExactCircle should  create circles with right number of planes
> -----------------------------------------------------------------
>                 Key: LUCENE-8071
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>         Attachments: LUCENE-8071-test.patch, LUCENE-8071.patch
> Hi [],
> There is still a situation when the test can fail. It happens when the planet model is
a SPHERE and the radius is slightly lower than PI. The circle is created with two sectors
but the circle plane is too big and the shape is bogus.
> I will attach a test and a proposed solution. (I hope this is the last issue of this

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message