lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11493) Unnecessary creation of singlton lists in DistributedUpdateProcessor
Date Thu, 19 Oct 2017 00:20:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210364#comment-16210364
] 

ASF subversion and git services commented on SOLR-11493:
--------------------------------------------------------

Commit 18c8091da5a35d6b0c19253b181b9e2468cd0a37 in lucene-solr's branch refs/heads/master
from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=18c8091 ]

SOLR-11464: SOLR-11493: Minor refactorings to DistributedUpdateProcessor


> Unnecessary creation of singlton lists in DistributedUpdateProcessor
> --------------------------------------------------------------------
>
>                 Key: SOLR-11493
>                 URL: https://issues.apache.org/jira/browse/SOLR-11493
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>            Reporter: Gus Heck
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: SOLR-11493.patch
>
>
> I thought I'd found another bug because one of 4 variants didn't have a loop, but then
I noticed that the method in question was being fed a list, and the very first thing it does
is loop that list... so it seems there is no need to loop the list, create and pass in a singleton
list, and then have the method loop that singleton list to process a single item... 
> Fixing this should save us a bit of object creation & therefore reduce GC load.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message