lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] [Created] (SOLR-11454) relax newSearcher based time checks in SoftAutoCommitTest
Date Mon, 09 Oct 2017 22:12:00 GMT
Hoss Man created SOLR-11454:

             Summary: relax newSearcher based time checks in SoftAutoCommitTest
                 Key: SOLR-11454
             Project: Solr
          Issue Type: Sub-task
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Hoss Man

The point of SoftAutoCommitTest is to ensure that auto-commits fire when expected.

The timing based checks on those autocommits are a semi-neccessary evil to ensure that the
test doesn't get false positives due to some other commits.
The test also sanity checks that auto-commits result in newSearcher events if/when they should
-- but these also (currently) have timing checks ot ensure that they happen "fast enough"
... this seems unneccessary (given the purpose of hte test) and broken (there's no guarantee/expectation
how fast a searcher will open, even though the test assumes it will be a number relative to
the autocommit setting.

we should relax these assertions, and just ensure that the searcher *eventually* opens in
a non-absurd amount of time, not fail if it isn't some specific math function relative to
other events.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message