lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joel Bernstein (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-11444) Improve Aliases.java and comma delimited collection list handling
Date Fri, 06 Oct 2017 17:38:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194919#comment-16194919
] 

Joel Bernstein edited comment on SOLR-11444 at 10/6/17 5:37 PM:
----------------------------------------------------------------

I also believe the get slices logic was in a number of different places in the streaming code
with slightly different implementations. It was then moved to the TupleStream where it's shared
by all the stream sources.  So when that consolidation was done it probably took the most
up to date version in CloudSolrClient.

I think it does make sense to use the CloudSolrClient version rather then having the TupleStream
have this logic.  


was (Author: joel.bernstein):
I also believe the get slices logic was in a number of different places in the streaming code
with slightly different implementations. It was then moved to the TupleStream where it's shared
by all the stream sources.  So when that consolidation was done it probably took the most
up to date version in CloudSolrClient.

I think it does make sense to use the CloudSolrClient version rather then having the streaming
have this logic.  

> Improve Aliases.java and comma delimited collection list handling
> -----------------------------------------------------------------
>
>                 Key: SOLR-11444
>                 URL: https://issues.apache.org/jira/browse/SOLR-11444
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>            Reporter: David Smiley
>            Assignee: David Smiley
>         Attachments: SOLR_11444_Aliases.patch
>
>
> While starting to look at SOLR-11299 I noticed some brittleness in assumptions about
Strings that refer to a collection.  Sometimes they are in fact references to comma separated
lists, which appears was added with the introduction of collection aliases (an alias can refer
to a comma delimited list).  So Java's type system kind of goes out the window when we do
this.  In one case this leads to a bug -- CloudSolrClient will throw an NPE if you try to
write to such an alias.  Sending an update via HTTP will allow it and send it to the first
in the list.
> So this issue is about refactoring and some little improvements pertaining to Aliases.java
plus certain key spots that deal with collection references.  I don't think I want to go as
far as changing the public SolrJ API except to adding documentation on what's possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message