lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Braun (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-11314) FastCharStream should avoid creating new IOExceptions as a signaling mechanism
Date Thu, 07 Sep 2017 00:29:00 GMT

     [ https://issues.apache.org/jira/browse/SOLR-11314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Braun updated SOLR-11314:
---------------------------------
    Attachment: Screen Shot 2017-09-06 at 8.21.18 PM.png

Attaching what it looks like in sampling - the creating of the new IOException is over half
of the time spent in the sample test application. 

> FastCharStream should avoid creating new IOExceptions as a signaling mechanism
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-11314
>                 URL: https://issues.apache.org/jira/browse/SOLR-11314
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 7.0, 6.6.1, master (8.0)
>            Reporter: Michael Braun
>         Attachments: Screen Shot 2017-09-06 at 8.21.18 PM.png, SOLR-11314.patch, TestQueryPerfSpeedup.java
>
>
> FastCharStream is used internally by solr query parser classes. It throws a new IOException
to signal the end. However, this is quite expensive relative to most operations and it shows
up very high on samples for extremely high query cases.  The IOException should be a single
static instance that can be shared to avoid the overhead in creation and populating the stack
trace, a stack trace which is never used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message