lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amrit Sarkar (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-11257) Only setting maxThreadCount for ConcurrentMergeScheduler (which is a user error) leads to a confusing validation error msg.
Date Sat, 02 Sep 2017 15:03:02 GMT

     [ https://issues.apache.org/jira/browse/SOLR-11257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Amrit Sarkar updated SOLR-11257:
--------------------------------
    Attachment: SOLR-11257.patch

[~thelabdude],

I faced the similar confusion configuring either of the maxThreadCount and maxMergeCount.
AUTO_DETECT_MERGES_AND_THREADS is resolved to {{-1}}, so better providing that information
than the constant variable name.

Also, {{ConcurrentMergeScheduler}} is part of Lucene, shouldn't we discuss this issue in LUCENE
project. Nevertheless, I attached a patch, just changed the error message as you mentioned:

{{Both maxMergeCount and maxThreadCount should be passed (unless default '-1') or None}}

> Only setting maxThreadCount for ConcurrentMergeScheduler (which is a user error) leads
to a confusing validation error msg.
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-11257
>                 URL: https://issues.apache.org/jira/browse/SOLR-11257
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Timothy Potter
>            Priority: Minor
>         Attachments: SOLR-11257.patch
>
>
> I tried tuning the maxThreadCount for my Concurrent scheduler using:
> {code}
>  <mergeScheduler class="org.apache.lucene.index.ConcurrentMergeScheduler">
>           <int name="maxThreadCount">4</int>
>        </mergeScheduler>
> {code}
> and got:
> {code}
> Validation errors:
> Error: java.lang.IllegalArgumentException:java.lang.IllegalArgumentException: both maxMergeCount
and maxThreadCount must be AUTO_DETECT_MERGES_AND_THREADS
> {code}
> Hmmm ... don't know what that means? As I user I need a better error message than that
^ Of course looking at the code, it seems I must also set: {{maxMergeCount}} but that error
doesn't tell me that. So this bug is about fixing up the error to be more helpful to the user.
Of course this is advanced functionality, so maybe expecting me to read the code to understand,
in which case, just close this as invalid.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message