lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mano Kovacs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-10912) Adding automatic patch validation
Date Mon, 11 Sep 2017 22:33:01 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162155#comment-16162155
] 

Mano Kovacs commented on SOLR-10912:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m 00s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m 00s{color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} Check examples refer correct lucene version {color}
| {color:green}  0m 05s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green}  0m 05s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green}  0m
05s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check licenses {color} | {color:green}  0m 05s{color}
| {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 24s{color} | {color:green}
facet in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  2m 46s{color} | {color:red}
analytics in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  4m 25s{color} | {color:red}
solrj in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 14s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-10912 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12886505/SOLR-10912.solj-contrib-facet-error.patch
|
| Optional Tests |  javac  unit  |
| uname | Darwin MunawAir.local 15.6.0 Darwin Kernel Version 15.6.0: Fri Feb 17 10:21:18 PST
2017; root:xnu-3248.60.11.4.1~1/RELEASE_X86_64 x86_64 |
| Build tool | ant |
| Personality | /Users/munaw/repos/lucene-solr/dev-tools/test-patch/solr-yetus-personality.sh
|
| git revision | master / 708ed8f |
| Default Java | 1.8.0_45 |
| unit | artifact/patchprocess/patch-unit-solr_contrib_analytics.txt |
| unit | artifact/patchprocess/patch-unit-solr_solrj.txt |
| modules | C: lucene/facet solr/contrib/analytics solr/solrj U: . |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Adding automatic patch validation
> ---------------------------------
>
>                 Key: SOLR-10912
>                 URL: https://issues.apache.org/jira/browse/SOLR-10912
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Build
>            Reporter: Mano Kovacs
>         Attachments: SOLR-10912.sample-patch.patch, SOLR-10912.solj-contrib-facet-error.patch
>
>
> Proposing introduction of automated patch validation, similar what Hadoop or other Apache
projects are using (see link). This would ensure that every patch passes a certain set of
criterions before getting approved. It would save time for developer (faster feedback loop),
save time for committers (less step to do manually), and would increase quality.
> Hadoop is currently using Apache Yetus to run validations, which seems to be a good direction
to start. This jira could be the board of discussing the preferred solution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message