lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Gerlowski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-7871) Platform independent config file instead of solr.in.sh and solr.in.cmd
Date Fri, 08 Sep 2017 03:30:02 GMT

    [ https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158067#comment-16158067
] 

Jason Gerlowski commented on SOLR-7871:
---------------------------------------

I like the "two-step rocket" approach, and will move forward with that.

I'm tempted to vote the other way...for the approach that your existing patch takes. (maintain
backcompat by emulating as much current shell/cmd logic as possible in Java-land).  It does
a great job of trimming logic from the bash/cmd scripts, which is a change I really want to
see (see SOLR-11206).  But it's hard to make the argument that that is required for this JIRA.
 The best thing is probably the simplest thing, as you pointed out above.

So I'll go forward with the approach you laid out above in your previous comment.

> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
>                 Key: SOLR-7871
>                 URL: https://issues.apache.org/jira/browse/SOLR-7871
>             Project: Solr
>          Issue Type: Improvement
>          Components: scripts and tools
>    Affects Versions: 5.2.1
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>              Labels: bin/solr
>         Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable batch files,
but all they do is to set environment variables for the start scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g. {{bin/solr.yml}}
or {{bin/solrstart.properties}} which is parsed by {{SolrCLI.java}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message