Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Thu, 24 Aug 2017 10:34:00 +0000 (UTC)
From: "Christine Poerschke (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.13095421.1502994328000.110505.1503570840927@Atlassian.JIRA>
In-Reply-To: <JIRA.13095421.1502994328000@Atlassian.JIRA>
References: <JIRA.13095421.1502994328000@Atlassian.JIRA> <JIRA.13095421.1502994328893@jira-lw-us.apache.org>
Subject: [jira] [Resolved] (SOLR-11254) add score-less (abstract)
 DocTransformer.transform method
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 24 Aug 2017 10:34:09 -0000


     [ https://issues.apache.org/jira/browse/SOLR-11254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christine Poerschke resolved SOLR-11254.
----------------------------------------
       Resolution: Fixed
    Fix Version/s: 7.1
                   master (8.0)

> add score-less (abstract) DocTransformer.transform method
> ---------------------------------------------------------
>
>                 Key: SOLR-11254
>                 URL: https://issues.apache.org/jira/browse/SOLR-11254
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>             Fix For: master (8.0), 7.1
>
>         Attachments: SOLR-11254.patch
>
>
> Background and motivation:
> * Most {{DocTransformer}} implementations don't use the {{score}} argument of the {{transform}} method.
> * Two-and-a-half of the three method callers pass {{0}} to indicate {{"no score"}}.
> ** https://github.com/apache/lucene-solr/blob/releases/lucene-solr/6.6.0/solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java#L253
> ** https://github.com/apache/lucene-solr/blob/releases/lucene-solr/6.6.0/solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java#L302
> ** https://github.com/apache/lucene-solr/blob/releases/lucene-solr/6.6.0/solr/core/src/java/org/apache/solr/response/DocsStreamer.java#L170
> * Without the change being proposed in this ticket the fix for SOLR-11180 and SOLR-11220 (included in the SOLR-11164 patch) would need to also interpret a score of {{0}} to mean {{"no score"}}.
> Summary of proposed change (for _master_ and _branch_7x_ branches):
> {code}
> -  public abstract void transform(SolrDocument doc, int docid, float score) throws IOException;
> +  public void transform(SolrDocument doc, int docid, float score) throws IOException {
> +    transform(doc, docid);
> +  }
> +
> +  public abstract void transform(SolrDocument doc, int docid) throws IOException;
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org