lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7941) GeoDegeneratePoints return intersects when located in edge shape
Date Sat, 26 Aug 2017 09:19:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142715#comment-16142715
] 

Karl Wright commented on LUCENE-7941:
-------------------------------------

[~ivera], this is what I did.

(1) I broadened the contract for the intersects(GeoShape) method to allow it to legally return
true when "within".  This is necessary because it's not just GeoDegeneratePoint objects that
might have difficulty computing intersection with edges, and by broadening this, we still
adhere to the contract of getRelationship() as it has been stated all along, which allows
WITHIN situations to be reported as OVERLAPS when computational difficulty arises.  At least,
I believe this to be true.  Please correct me if I am wrong.

(2) I changed the implementation of GeoDegeneratePoint.intersects(GeoShape) accordingly.

Please note that, because of this solution, asymmetrical  getRelationship() results are expected
for the objects that report OVERLAPS instead of WITHIN for getRelationship(GeoShape), and
for methods which report "true" for intersects(GeoShape) in a WITHIN situation.  So I did
not commit your test; you will probably want to modify it and resubmit the patch when you
are ready.

Thanks!



> GeoDegeneratePoints return intersects when located in edge shape 
> -----------------------------------------------------------------
>
>                 Key: LUCENE-7941
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7941
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Minor
>         Attachments: LUCENE-7941-test.patch
>
>
>  If the degenerate Geopoint lays on the boundary of a shape, the relationships between
the objects are not symetrical:
> The bounding box "thinks" it contains the degenerated point.
> The degenerated point "thinks" it intersects the shape.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message