lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Wright (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7934) PlanetObject Interface
Date Sun, 20 Aug 2017 11:18:02 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134385#comment-16134385
] 

Karl Wright commented on LUCENE-7934:
-------------------------------------

This seems pretty reasonable to me.  If it passes precommit, I'm happy to commit it.


> PlanetObject Interface
> ----------------------
>
>                 Key: LUCENE-7934
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7934
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>         Attachments: LUCENE-7934.patch
>
>
> Hi [~daddywri],
> I propose to add a new interface call PlanetObject which all shapes should implement.
It is actually extracted from class BasePlanetObject. The motivation is that currently the
method getPlanetModel() is not visible and therefore there is no possibility to know to which
PlanetModel a shape belongs to. 
> The side effect for this change is that the constructors for composite shapes change
as they need to be created with a PlanetModel. I think this is correct as then we can check
the planet model when adding a shape and make sure all objects in a composite belongs to the
same Planet model.
> In addition, we check that two shape belongs to the shape Planet model when calling getRelationship(GeoShape
geoShape).  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message