lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7901) original/default Highlighter's constructor should throw if passed null args
Date Tue, 18 Jul 2017 15:00:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091672#comment-16091672
] 

ASF subversion and git services commented on LUCENE-7901:
---------------------------------------------------------

Commit 80ddc6728f45c88d3e2c5b8563b0a35ad7895d0a in lucene-solr's branch refs/heads/branch_7_0
from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=80ddc67 ]

LUCENE-7901

(cherry picked from commit 0971fe6)


> original/default Highlighter's constructor should throw if passed null args
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-7901
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7901
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>            Reporter: David Smiley
>            Priority: Minor
>         Attachments: LUCENE-7901.patch, LUCENE-7901.patch
>
>
> The default/original Highlighter has a constructor that takes several parameters, including
an Encoder.  If per chance these are null, we'll throw an exception later at highlight time
but it's nicer to get an exception eagerly.  It will also avoid the LUCENE-6979 trap.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message