Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Sat, 10 Jun 2017 02:34:18 +0000 (UTC)
From: "Jason Gerlowski (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: <JIRA.13078304.1496925806000.44685.1497062058072@Atlassian.JIRA>
In-Reply-To: <JIRA.13078304.1496925806000@Atlassian.JIRA>
References: <JIRA.13078304.1496925806000@Atlassian.JIRA> <JIRA.13078304.1496925806260@jira-lw-us.apache.org>
Subject: [jira] [Updated] (SOLR-10850) HttpSolrClient Javadoc examples
 reference nonexistent constructors
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 10 Jun 2017 02:34:22 -0000


     [ https://issues.apache.org/jira/browse/SOLR-10850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Gerlowski updated SOLR-10850:
-----------------------------------
    Attachment: SOLR-10850.patch

I've attached a patch updating the Javadoc.  Pretty trivial change


> HttpSolrClient Javadoc examples reference nonexistent constructors
> ------------------------------------------------------------------
>
>                 Key: SOLR-10850
>                 URL: https://issues.apache.org/jira/browse/SOLR-10850
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrJ
>    Affects Versions: master (7.0)
>            Reporter: Jason Gerlowski
>            Priority: Minor
>             Fix For: master (7.0)
>
>         Attachments: SOLR-10850.patch
>
>
> A recent [JIRA|https://issues.apache.org/jira/browse/SOLR-10755] removed a number of deprecated constructors from the SolrClient implementations.
> In the case of {{HttpSolrClient}}, the top-level Javadocs contain instantiation instructions that still reference the old constructors:
> e.g.
> {code}
> /**
>  * A SolrClient implementation that talks directly to a Solr server via HTTP
>  *
>  * There are two ways to use an HttpSolrClient:
>  *
>  * 1) Pass a URL to the constructor that points directly at a particular core
>  * <pre>
>  *   SolrClient client = new HttpSolrClient("http://my-solr-server:8983/solr/core1");
>  *   QueryResponse resp = client.query(new SolrQuery("*:*"));
>  * </pre>
>  * In this case, you can query the given core directly, but you cannot query any other
>  * cores or issue CoreAdmin requests with this client.
>  *
>  * 2) Pass the base URL of the node to the constructor
>  * <pre>
>  *   SolrClient client = new HttpSolrClient("http://my-solr-server:8983/solr");
>  *   QueryResponse resp = client.query("core1", new SolrQuery("*:*"));
>  * </pre>
>  * In this case, you must pass the name of the required core for all queries and updates,
>  * but you may use the same client for all cores, and for CoreAdmin requests.
>  */
> {code}
> These Javadocs should be updated with examples that use the client Builder types.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org