Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
From: m-khl <git@git.apache.org>
To: dev@lucene.apache.org
Reply-To: dev@lucene.apache.org
References: <git-pr-202-lucene-solr@git.apache.org>
In-Reply-To: <git-pr-202-lucene-solr@git.apache.org>
Subject: [GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...
Content-Type: text/plain
Message-Id: <20170607203650.A762FDFC2E@git1-us-west.apache.org>
Date: Wed,  7 Jun 2017 20:36:50 +0000 (UTC)
archived-at: Wed, 07 Jun 2017 20:36:52 -0000

Github user m-khl commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/202#discussion_r120737742
  
    --- Diff: solr/core/src/java/org/apache/solr/response/transform/DocTransformer.java ---
    @@ -41,12 +41,26 @@
        */
       public abstract String getName();
     
    +
    +  /**
    +   * This is called before {@link #transform} to provide context for any subsequent transformations.
    +   *
    +   * @param context The {@link ResultContext} stores information about how the documents were produced.
    +   * @see #needsSolrIndexSearcher
    +   */
    +  public void prepare( ResultContext context ) {
    --- End diff --
    
    I suppose if anything can be done with existing facilities, they should be utilised. I don't take it much if some name is misleading. We have a lot of much more severe issues and live with them.  -1 for "just add"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org