lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrien Grand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7880) Make boolean query clause limit configurable per-query
Date Sun, 18 Jun 2017 21:42:02 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053319#comment-16053319
] 

Adrien Grand commented on LUCENE-7880:
--------------------------------------

Mark, what is your proposal?

This issue looks like a tentative to workaround the fact that there was disagreement about
removing the limit entirely in LUCENE-4835. However adding a per-query API feels even worse
to me. It adds an unnecessary method to one of the main classes of our API, and will contaminate
many other classes like query parsers, maybe MoreLikeThis, etc. if we want to be able to set
different limits on boolean queries that these classes generate too.

> Make boolean query clause limit configurable per-query
> ------------------------------------------------------
>
>                 Key: LUCENE-7880
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7880
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Yonik Seeley
>
> As we know, the magic BooleanQuery.maxClauseCount has bitten many people over time.
> It's also a static, which really hurts multi-tenancy (i.e. we can't have different settings
for different users, clients, or use-cases).
> If we want to keep this static as a default, then at least we should allow it to be overridden
on a per-query basis when we know it is the desired behavior and not a bug.
> Perhaps the simplest way to achieve this would be a setter on BooleanQuery.Builder that
configures the limit for that instance only?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message