lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-10864) Add static (test only) boolean to PointField indicating 'precisionStep' should be ignored so we can simplify points randomization in our schemas
Date Fri, 30 Jun 2017 18:24:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070518#comment-16070518
] 

ASF subversion and git services commented on SOLR-10864:
--------------------------------------------------------

Commit f3c851a015e5d8c775f0fb28ffbd8f5725f2f11b in lucene-solr's branch refs/heads/master
from Chris Hostetter
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f3c851a ]

SOLR-10864: Fixup: Restore the DV vs trie vs points intent of TestRandomDVFaceting


> Add static (test only) boolean to PointField indicating 'precisionStep' should be ignored
so we can simplify points randomization in our schemas
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-10864
>                 URL: https://issues.apache.org/jira/browse/SOLR-10864
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>             Fix For: master (7.0)
>
>         Attachments: SOLR-10864.patch, SOLR-10864.patch, SOLR-10864.patch, SOLR-10864.patch,
SOLR-10864.patch, SOLR-10864.patch
>
>
> (I'm spinning this idea out of parent jira SOLR-10807 so that it gets it's own jira#
w/ it's own summary for increased visibility/comments)
> In the interest of making it easier & more straight forward to get good randomized
test coverage of Points fields, I'd like to add the following to the {{PointField}} class...
> {code}
>  /**
>   * <p>
>   * The Test framework can set this global variable to instruct PointField that
>   * (on init) it should be tollerant of the <code>precisionStep</code> argument
used by TrieFields.
>   * This allows for simple randomization of TrieFields and PointFields w/o extensive
duplication
>   * of <code>&lt;fieldType/&gt;</code> declarations.
>   * </p>
>   *
>   * <p>NOTE: When {@link TrieField} is removed, this boolean must also be removed</p>
>   *
>   * @lucene.internal
>   * @lucene.experimental
>   */
>  public static boolean TEST_HACK_IGNORE_USELESS_TRIEFIELD_ARGS = false;
>  /** 
>   * NOTE: This method can be removed completely when
>   * {@link #TEST_HACK_IGNORE_USELESS_TRIEFIELD_ARGS} is removed 
>   */
>  @Override
>  protected void init(IndexSchema schema, Map<String, String> args) {
>    super.init(schema, args);
>    if (TEST_HACK_IGNORE_USELESS_TRIEFIELD_ARGS) {
>      args.remove("precisionStep");
>    }
>  }
> {code}
> Then in SolrTestCaseJ4, set {{PointField.TEST_HACK_IGNORE_USELESS_TRIEFIELD_ARGS}} on
a class by class basis when randomizing Trie/Points (and unset \@AfterClass).
> (details to follow in comment)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message