lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christine Poerschke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-10671) tweak SolrMetricReporter implementations' init/validate/start logic
Date Wed, 07 Jun 2017 11:25:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040725#comment-16040725
] 

Christine Poerschke commented on SOLR-10671:
--------------------------------------------

Hi Varun,

Yes, since this breaks back-compat the change is intentionally for master only. CHANGES.txt
already has a short note in the "Upgrading from Solr 6.x" section, feel free to revise or
extend it if it's perhaps too short?

You mention writing your own custom reporter, SOLR-10823 and SOLR-10827 might also be of interest
to you then if your custom reporter has a reporting period and/or filtering logic.

> tweak SolrMetricReporter implementations' init/validate/start logic
> -------------------------------------------------------------------
>
>                 Key: SOLR-10671
>                 URL: https://issues.apache.org/jira/browse/SOLR-10671
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>             Fix For: master (7.0)
>
>         Attachments: SOLR-10671.patch, SOLR-10671.patch
>
>
> This ticket proposes to
> * add abstract doInit method to the SolrMetricReporter base class
> * turn Solr(Cluster|Shard)Reporter.validate into Solr(Cluster|Shard)Reporter.doInit
> * factor out Solr(Ganglia|Graphite|Slf4j)Reporter.doInit from Solr(Ganglia|Graphite|Slf4j)Reporter.validate
> Motivation and Intention:
> * Consistency w.r.t. what logic SolrMetricReport implementations should place in which
method.
> * Even reporters that are not enabled to pass the validate() check.
> * The validate() method to have no (init-ialising) side effects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message