lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Trey Grainger (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-10494) Switch Solr's Default Response Type from XML to JSON
Date Tue, 27 Jun 2017 05:24:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064287#comment-16064287
] 

Trey Grainger edited comment on SOLR-10494 at 6/27/17 5:23 AM:
---------------------------------------------------------------

Ok, I think I'm nearly done. This patch ([^SOLR-10494.patch]) includes removing all the extraneous
"wt=json" and "indent=on" references, adding a commented out version of "wt=xml" to the example
solrconfig.xml's, unit test updates, some additional updates to the tutorials and docs (also
incorporating [~ctargett]'s), and updating the admin UI (query section) to handle the new
defaults.

The only issue I'm running into is that for some reason I haven't figured out yet, turning
"indent" on has broken some of the parent/child relationship tests (i.e. TestHierarchicalDocBuilder.testThreeLevelHierarchy,
SolrExampleTests.testChildDocTransformer. It initially appears to be some xml parsing issue
issue with the extra whitespace, which would be odd, but I haven't dug in yet.  Once I figure
those out, I'll update the patch, and then I think this will be ready for review.


was (Author: solrtrey):
Ok, I think I'm nearly done. This patch includes removing all the extraneous "wt=json" and
"indent=on" references, adding a commented out version of "wt=xml" to the example solrconfig.xml's,
unit test updates, some additional updates to the tutorials and docs (also incorporating [~ctargett]'s),
and updating the admin UI (query section) to handle the new defaults.

The only issue I'm running into is that for some reason I haven't figured out yet, turning
"indent" on has broken some of the parent/child relationship tests (i.e. TestHierarchicalDocBuilder.testThreeLevelHierarchy,
SolrExampleTests.testChildDocTransformer. It initially appears to be some xml parsing issue
issue with the extra whitespace, which would be odd, but I haven't dug in yet.  Once I figure
those out, I'll update the patch, and then I think this will be ready for review.

> Switch Solr's Default Response Type from XML to JSON
> ----------------------------------------------------
>
>                 Key: SOLR-10494
>                 URL: https://issues.apache.org/jira/browse/SOLR-10494
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: master (7.0)
>            Reporter: Trey Grainger
>            Priority: Blocker
>             Fix For: master (7.0)
>
>         Attachments: SOLR-10494, SOLR-10494, SOLR-10494.patch, SOLR-10494-withdocs.patch,
SOLR-10494-withdocs.patch
>
>
> Solr's default response format is still XML, despite the fact that Solr has supported
the JSON response format for over a decade, developer mindshare has clearly shifted toward
JSON over the years, and most modern/competing systems also use JSON format now by default.
> In fact, Solr's admin UI even explicitly adds wt=json to the request (by default in the
UI) to override the default of wt=xml, so Solr's Admin UI effectively has a different default
than the API.
> We have now introduced things like the JSON faceting API, and the new more modern /V2
apis assume JSON for the areas of Solr they cover, so clearly we're moving in the direction
of JSON anyway.
> I'd like propose that we switch the default response writer to JSON (wt=json) instead
of XML for Solr 7.0, as this seems to me like the right direction and a good time to make
this change with the next major version.
> Based upon feedback from the Lucene Dev's mailing list, we want to:
> 1) Change the default response writer type to "wt=json" and also change to "indent=on"
by default
> 2) Make no changes on the update handler side; it already works as desired (it returns
the response in the same content-type as the request unless the "wt" is passed in explicitly).
> 3) Keep the /query request handler around since people have already used it for years
to do JSON queries
> 4) Add a commented-out "wt=xml" to the solrconfig.xml as a reminder for folks on how
to change (back) the response format.
> The default format change, plus the addition of "indent=on" are back compat changes,
so we need to make sure we doc those clearly in the CHANGES.txt. There will also need to be
significant adjustments to the Solr Ref Guide, Tutorial, etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message