lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From diegoceccarelli <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #202: SOLR-10703 Add prepare and finish in DocTrasf...
Date Wed, 07 Jun 2017 17:54:11 GMT
Github user diegoceccarelli commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/202#discussion_r120698740
  
    --- Diff: solr/core/src/java/org/apache/solr/response/DocsStreamer.java ---
    @@ -142,6 +142,11 @@ public boolean hasNext() {
         return docIterator.hasNext();
       }
     
    +  // called at the end of the stream
    --- End diff --
    
    the reason for `prepare` and `finish` was to have the same naming of components, imo it
makes easier to understand what's going on, I do like the Closeable idea, do you think it
would be better?
    
    > Also, line 89 still calls setContext() .. is it right? or I'm missing something?
    
    No, I missed line 89, thank you


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message