lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ignacio Vera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7853) Request to change visibility of classes in geo3d
Date Tue, 30 May 2017 12:28:04 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029353#comment-16029353
] 

Ignacio Vera commented on LUCENE-7853:
--------------------------------------

New patch attached, this time looks what you expect I hope. 

Thanks for he answer. In my case I would have to simplify the polygon to its minimal description
because of performance. I can do that at indexing time.

Cheers,

I.



> Request to change visibility of classes in geo3d
> ------------------------------------------------
>
>                 Key: LUCENE-7853
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7853
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>         Attachments: LUCENE-7853.patch
>
>
> I  am creating my own spatial context by wrapping the objects in lucene geo3d library
and implement my own query which mixes the recursive and the serialized strategy to add precision
to searches. 
>  
> I had the following issue specially with polygons:  The factory for creating polygons
is slow and when serializing shapes, I already know if I am dealing with convex or concave
polygons (in my case they are always concave). So when de-serializing a polygon I do not want
to go through the factory to decide the type of polygon to create.
>  
> Wouldn't make sense to add the possibility to create a type of polygon directly? you
cannot create the polygons directly as they are protected in the package. My suggestion request
would be either to add methods in the polygon factory to create a type of polygons with no
checking (e.g. makeConcavePolygon(…)) or change the visibility of the classes so that they
can be instantiated directly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message