lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7801) SortedSetDocValuesReaderState should implement Accountable
Date Mon, 24 Apr 2017 22:18:04 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982005#comment-15982005
] 

Robert Muir commented on LUCENE-7801:
-------------------------------------

ok but i still think i would just pass the map to https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/util/Accountables.java#L100
rather than doing it one by one in your own loop.

It should be doing the same thing, only with less annoyances (e.g. field names will be sorted
rather than haphazard, etc)

> SortedSetDocValuesReaderState should implement Accountable
> ----------------------------------------------------------
>
>                 Key: LUCENE-7801
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7801
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: master (7.0), 6.6
>
>         Attachments: LUCENE-7801.patch, LUCENE-7801.patch
>
>
> This class is used by sorted set facets, and wraps per-dimension {{MultiDocValues.OrdinalMap}}
which already implement accountable, and it's helpful to know how much heap this structure
is taking for computing Lucene's SSDV facets.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message