lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7796) Make reThrow idiom declare Error return type so callers may use it in a way that compiler knows subsequent code is unreachable
Date Wed, 26 Apr 2017 17:01:04 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985144#comment-15985144
] 

Hoss Man commented on LUCENE-7796:
----------------------------------

bq. Let me know what you think, especially Hoss Man since you provided an alternative view
...

I don't have strong opinions on this at all, i was just putting out some strawmen to address
the two diff calling models you were trying to fix w/minimal changes -- unifying those models
to force the caller to do the null check is completely fine with me.

> Make reThrow idiom declare Error return type so callers may use it in a way that compiler
knows subsequent code is unreachable
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7796
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7796
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 6.x, master (7.0)
>
>         Attachments: LUCENE-7796.patch
>
>
> A spinoff from LUCENE-7792: reThrow can be declared to return an unchecked exception
so that callers can choose to use {{throw reThrow(...)}} as an idiom to let the compiler know
any subsequent code will be unreachable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message