lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ishan Chattopadhyaya (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-10272) Use a default configset and make the configName parameter optional.
Date Tue, 25 Apr 2017 16:07:04 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983115#comment-15983115
] 

Ishan Chattopadhyaya edited comment on SOLR-10272 at 4/25/17 4:06 PM:
----------------------------------------------------------------------

Adding a patch for this. 

# It bootstraps the data_driven_schema_configs as _default upon startup and uses it for creating
collections when configset name is not specified.
# TODO: Resolve a few minor nocommits (documentation etc.)
# There is no change in behaviour from bin/solr script, but internally it is using the _default
when collection name is not specified.
# Behaviour so far has been: if collections API's CREATE command is called without a configName,
and there is only 1 configset uploaded, it is used for creating the collection. However, with
the _default being bootstrapped, *this behaviour would be broken*, and in such a case the
_default would be used. *This is a break in backcompat (if we do this in branch_6x), but I
think it is okay to do this for the sake of consistency (script vs. collections API). If someone
thinks otherwise, I can commit this issue only for master/7.0*.
# The tests can use the _default if we add a data_driven_schema_configs folder to solr/core/src/test-files/solr/configsets
folder or use the "solr.default.configdir" sysprop. I have not changed existing tests to do
this, so as to minimize this patch size. It can be done separately.


was (Author: ichattopadhyaya):
Adding a patch for this. 

# It bootstraps the data_driven_schema_configs as _default upon startup and uses it for creating
collections when collection name is not specified.
# TODO: Resolve a few minor nocommits (documentation etc.)
# There is no change in behaviour from bin/solr script, but internally it is using the _default
when collection name is not specified.
# Behaviour so far has been: if collections API's CREATE command is called without a configName,
and there is only 1 configset uploaded, it is used for creating the collection. However, with
the _default being bootstrapped, this behaviour would be broken, and in such a case the _default
would be used. This is a break in backcompat (if we do this in branch_6x), but I think it
is okay to do this for the sake of consistency (script vs. collections API). If someone things
otherwise, I can commit this issue only for master/7.0.
# The tests can use the _default if we add a data_driven_schema_configs folder to solr/core/src/test-files/solr/configsets
folder or use the "solr.default.configdir" sysprop. I have not changed existing tests to do
this, so as to minimize this patch size. It can be done separately.

> Use a default configset and make the configName parameter optional.
> -------------------------------------------------------------------
>
>                 Key: SOLR-10272
>                 URL: https://issues.apache.org/jira/browse/SOLR-10272
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Varun Thacker
>            Assignee: Ishan Chattopadhyaya
>         Attachments: SOLR-10272.patch
>
>
> This Jira's motivation is to improve the creating a collection experience better for
users.
> To create a collection we need to specify a configName that needs to be present in ZK.
When a new user is starting Solr why should he worry about having to know about configsets
before he can can create a collection.
> When you create a collection using "bin/solr create" the script uploads a configset and
references it. This is great. We should extend this idea to API users as well.
> So here is the rough outline of what I think we can do here:
> 1. When you start solr , the bin script checks to see if "/configs/_baseConfigSet" znode
is present . If not it uploads the "basic_configs". 
> We can discuss if its the "basic_configs" or something other default config set. 
> Also we can discuss the name for "/_baseConfigSet". Moving on though
> 2. When a user creates a collection from the API  {{admin/collections?action=CREATE&name=gettingstarted}}
here is what we do :
> Use https://cwiki.apache.org/confluence/display/solr/ConfigSets+API to copy over the
default config set to a configset with the name of the collection specified.
> collection.configName can truly be an optional parameter. If its specified we don't need
to do this step.
> 3. Have the bin scripts use this and remove the logic built in there to do the same thing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message