lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-10152) PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)
Date Wed, 01 Mar 2017 14:15:45 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890240#comment-15890240
] 

David Smiley commented on SOLR-10152:
-------------------------------------

Yes.  (continue discussion on SOLR-1053 please).  I'll commit both issues together.

> PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-10152
>                 URL: https://issues.apache.org/jira/browse/SOLR-10152
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: highlighter
>            Reporter: Amrit Sarkar
>         Attachments: SOLR-10152.patch
>
>
> Lucene 5.3 added a CustomSeparatorBreakIterator (see LUCENE-6485)
> SOLR-10152.patch uploaded which incorporates CustomSeparatorBreakIterator in PostingsSolrHighlighter.
> - added a new request param option to specify which separator char to use. *customSeparatorChar*.
> - changed PostingsSolrHighlighter.getBreakIterator to check HighlightParams.BS_TYPE first.
> - if type=='CUSTOM', look for the new separator param, in getBreakIterator, validate
it's a single char, & skip locale parsing.
> - 'WHOLE' option moved from parseBreakIterator to getBreakIterator, as it doesn't depend
on locale.
> Changes made in:
> * HighlightParams.java
> * PostingsSolrHighlighter.java
> * test cases added in TestPostingsSolrHighlighter



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message