lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsmiley <...@git.apache.org>
Subject [GitHub] lucene-solr pull request #169: Add status return for replication SOLR-10249
Date Wed, 22 Mar 2017 19:51:27 GMT
Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/169#discussion_r107512860
  
    --- Diff: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java ---
    @@ -311,7 +359,7 @@ boolean fetchLatestIndex(boolean forceReplication, boolean forceCoreReload)
thro
             Replica replica = getLeaderReplica();
             CloudDescriptor cd = solrCore.getCoreDescriptor().getCloudDescriptor();
             if (cd.getCoreNodeName().equals(replica.getName())) {
    -          return false;
    +          return IndexFetchResult.CORE_NODE_IS_REPLICA;
    --- End diff --
    
    Maybe call this NOT_LEADER ?  Even a leader is a replica (it's the _role_ a replica plays).
 Granted many of us promote this ambiguity because we haven't clearly/consistently labelled
a non-leader, e.g. a follower.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message