lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7706) Update MergeScheduler's documentation - clone() is no longer there
Date Thu, 23 Feb 2017 10:52:44 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880250#comment-15880250
] 

ASF subversion and git services commented on LUCENE-7706:
---------------------------------------------------------

Commit 8ed8ecfc7e972d8dbbf02497f53da54b1d6b8461 in lucene-solr's branch refs/heads/master
from [~dawid.weiss]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8ed8ecf ]

LUCENE-7706: Update MergeScheduler's documentation - clone() is no longer there


> Update MergeScheduler's documentation - clone() is no longer there
> ------------------------------------------------------------------
>
>                 Key: LUCENE-7706
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7706
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 6.x, master (7.0)
>
>
> I didn't look too closely, but MergeScheduler has this piece of documentation:
> {code}
>  *  <p>Implementers of sub-classes should make sure that {@link #clone()}
>  *  returns an independent instance able to work with any {@link IndexWriter}
>  *  instance.</p>
> {code}
> Now, we don't seem to be using this at all... I think. MergeScheduler doesn't even implement
Cloneable. But in any case, I think it'd be better to provide an abstract covariant of this
sort:
> {code}
> public abstract MergeScheduler clone() {
>   return this;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message