lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-10009) Explore removing CoreDescriptor from SolrCore
Date Fri, 03 Feb 2017 05:21:51 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851085#comment-15851085
] 

David Smiley commented on SOLR-10009:
-------------------------------------

What you're saying makes sense though I confess not being that familiar with these internals.
 BTW I suggest not naming a class {{CoreDescriptors}} and instead do almost anything else
as it's too confusing -- just one letter from what it manages.  I'm not entirely clear why
a CoreDescriptors or SolrCores (which I just observed in the code base) needs to exist when
we already have the CoreContainer which one would think is going to handle that itself.  Maybe
it's grown in complexity that this stuff is factored out?

> Explore removing CoreDescriptor from SolrCore
> ---------------------------------------------
>
>                 Key: SOLR-10009
>                 URL: https://issues.apache.org/jira/browse/SOLR-10009
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>
> There should be one place where the CoreDescriptor resides, not a copy in CoreContainer
and one in SolrCore. Changing and persisting these from one place or the other leads to inconsistencies.
> This JIRA is partly to get the discussion going of how to untangle these.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message