Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 129A3200BFD for ; Sun, 15 Jan 2017 23:45:35 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1117A160B32; Sun, 15 Jan 2017 22:45:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5CDDC160B2B for ; Sun, 15 Jan 2017 23:45:34 +0100 (CET) Received: (qmail 90342 invoked by uid 500); 15 Jan 2017 22:45:33 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 90332 invoked by uid 99); 15 Jan 2017 22:45:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Jan 2017 22:45:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C7E65C059C for ; Sun, 15 Jan 2017 22:45:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 296lsqwWIUfs for ; Sun, 15 Jan 2017 22:45:32 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 568185F286 for ; Sun, 15 Jan 2017 22:45:31 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 871E3E5AB7 for ; Sun, 15 Jan 2017 22:45:28 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7D76925287 for ; Sun, 15 Jan 2017 22:45:26 +0000 (UTC) Date: Sun, 15 Jan 2017 22:45:26 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@lucene.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SOLR-9303) Refactor CloudSolrClient for extensibility MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 15 Jan 2017 22:45:35 -0000 [ https://issues.apache.org/jira/browse/SOLR-9303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823302#comment-15823302 ] ASF GitHub Bot commented on SOLR-9303: -------------------------------------- Github user paulo-raca closed the pull request at: https://github.com/apache/lucene-solr/pull/51 > Refactor CloudSolrClient for extensibility > ------------------------------------------ > > Key: SOLR-9303 > URL: https://issues.apache.org/jira/browse/SOLR-9303 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ > Affects Versions: 5.4, 6.0 > Reporter: Paulo Costa > Priority: Minor > Labels: SolrCloud, solrj > Fix For: 6.1 > > Original Estimate: 24h > Remaining Estimate: 24h > > I'm using a custom Solr plugins which adds extra constraints on which nodes I can access. > To respect these constraints, I needed to use a customized version of CloudSolrClient. > Unfortunately, CloudSolrClient.sendRequest() is currently written as one big chunk of code, breaking OO's SOLID principle and making it is impossible for me to customize it on a subclass. > I suggest we refactor this method in 3 steps: > - Finding the usable URLs > - Checking if a node can be used for this request > - Executing the request -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org