lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Braun (JIRA)" <j...@apache.org>
Subject [jira] (SOLR-10080) Fix some issues reported by findbugs
Date Tue, 31 Jan 2017 21:55:51 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847585#comment-15847585
] 

Michael Braun commented on SOLR-10080:
--------------------------------------

In BlobRepository the only use of that synchronized call I can see on first glance would be
to prevent blobCreator.call from executing twice, but the same thing can be accomplished by
using .computeIfAbsent. 

> Fix some issues reported by findbugs 
> -------------------------------------
>
>                 Key: SOLR-10080
>                 URL: https://issues.apache.org/jira/browse/SOLR-10080
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Pushkar Raste
>            Priority: Minor
>         Attachments: SOLR-10080.patch
>
>
> I ran a findbugs analysis on code and found a lot of issues. I found issues in both lucene
and solr, however, I am not sure whether Solr developers should fix issues like this in the
lucene code or not.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message