lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ishan Chattopadhyaya (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9777) IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of getCoreCacheKey() for per-segment caching
Date Fri, 06 Jan 2017 13:46:58 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804572#comment-15804572
] 

Ishan Chattopadhyaya commented on SOLR-9777:
--------------------------------------------

I'm planning to commit this soon. So, if someone has the time to review this change, would
be great.

> IndexFingerprinting: use getCombinedCoreAndDeletesKey() instead of  getCoreCacheKey()
for per-segment caching
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-9777
>                 URL: https://issues.apache.org/jira/browse/SOLR-9777
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>            Assignee: Noble Paul
>         Attachments: SOLR-9777.patch
>
>
> [Note: Had initially posted to SOLR-9506, but now moved here]
> While working on SOLR-5944, I realized that the current per segment caching logic works
fine for deleted documents (due to comparison of numDocs in a segment for the criterion of
cache hit/miss). However, if a segment has docValues updates, the same logic is insufficient.
It is my understanding that changing the key for caching from reader().getCoreCacheKey() to
reader().getCombinedCoreAndDeletesKey() would work here, since the docValues updates are internally
handled using deletion queue and hence the "combined" core and deletes key would work here.
Attaching a patch for the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message